Repository navigation
test: close the two branch coverage gaps - #83
Merged
Merged
Conversation
Branch coverage has not been 100% in CI for at least two months (99.36% on the latest main run). Two branches were never taken: - cache.ts:28 - the "/opt/hostedtoolcache" fallback. A runner always sets RUNNER_TOOL_CACHE, so the fallback is only reached when a test clears it. Locally the opposite holds, which is why this gap is invisible outside CI. - version.ts:112 - the wrapper for a rejection that is not an Error. Neither surfaces on Codecov: the clover report records both lines as type="cond" truecount="1" falsecount="1", so the uncovered branches never reach the upload. Verified 317/317 both with and without RUNNER_TOOL_CACHE set. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch coverage has not been 100% in CI for at least two months — the latest run on
mainreports 99.36%. Two branches were never taken.cache.ts:28A runner always sets
RUNNER_TOOL_CACHE, so the fallback is only reached when a test clears it. Locally the opposite holds — the variable is unset, so the fallback is taken naturally and the gap is invisible outside CI.version.ts:112The
error instanceof Error ? error : new Error(String(error))wrapper infetchManifesthad no test for a rejection that is not anError.Why Codecov still shows 100%
The clover report records both lines as
type="cond" truecount="1" falsecount="1"— fully covered — so the uncovered branches never reach the upload. Codecov's headline number is line coverage, which has been 100% throughout.Verified 317/317 both with and without
RUNNER_TOOL_CACHEset.🤖 Generated with Claude Code